DX-108149: Add support for GCM encryption mode #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
timhurskidremio
force-pushed
the
add-support-for-gcm-encryption-mode
branch
from
b2df3f4 to
5e5cf1b
Compare
timhurskidremio
force-pushed
the
add-support-for-gcm-encryption-mode
branch
2 times, most recently
from
c3ef53f to
70977aa
Compare
timhurskidremio
force-pushed
the
add-support-for-gcm-encryption-mode
branch
2 times, most recently
from
b4eb85f to
cae639b
Compare
- Create ensure_mode() helper that throws std::runtime_error for invalid modes - Update all 6 AES functions (3 encrypt + 3 decrypt) to use ensure_mode() - ECB, CBC, GCM encrypt functions now use centralized mode validation - ECB, CBC, GCM decrypt functions now use centralized mode validation - Remove redundant mode validation code from all functions - Wrap all function bodies in try-catch to handle exceptions from ensure_mode() - Consistent error handling across all modes
timhurskidremio
force-pushed
the
add-support-for-gcm-encryption-mode
branch
from
cae639b to
77da0d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.